serverless support import into (#20832) #20845
Conversation
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
ti-chi-bot
added
first-time-contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the documentation to reflect the availability of IMPORT INTO ... FROM FILE on TiDB Cloud Serverless, clarifying which storage options are supported. It also removes notes indicating that CANCEL IMPORT and SHOW IMPORT are unavailable on TiDB Cloud Serverless, and adds a note that Global Sort is not available on TiDB Cloud Serverless.
Highlights
- Feature Update: The
IMPORT INTO ... FROM FILEfeature is now supported on TiDB Cloud Serverless, with support for Amazon S3 and Alibaba Cloud OSS. - Documentation Update: The documentation has been updated to reflect the availability of
IMPORT INTO ... FROM FILEon TiDB Cloud Serverless and the unavailability of Global Sort. - Note Removal: The documentation has been updated to remove notes indicating that
CANCEL IMPORTandSHOW IMPORTare unavailable on TiDB Cloud Serverless.
Changelog
- sql-statements/sql-statement-cancel-import-job.md
- Removed note indicating that
CANCEL IMPORTis unavailable on TiDB Cloud Serverless.
- Removed note indicating that
- sql-statements/sql-statement-import-into.md
- Updated documentation to reflect the availability of
IMPORT INTO ... FROM FILEon TiDB Cloud Serverless. - Specified that TiDB Cloud Serverless supports importing data from files stored in Amazon S3 and Alibaba Cloud OSS.
- Added a note that Global Sort is not available on TiDB Cloud Serverless.
- Updated documentation to reflect the availability of
- sql-statements/sql-statement-show-import-job.md
- Removed note indicating that
SHOW IMPORTis unavailable on TiDB Cloud Serverless.
- Removed note indicating that
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request removes notes indicating that certain features are unavailable on TiDB Cloud Serverless clusters and updates the supported storage for IMPORT INTO on TiDB Cloud Serverless. The changes seem straightforward and necessary to reflect the current capabilities of TiDB Cloud Serverless. I have provided some minor feedback to improve clarity and adherence to the style guide.
Summary of Findings
- Clarity and Completeness: Ensured that the documentation accurately reflects the features available on TiDB Cloud Serverless, specifically regarding data import and global sort capabilities.
- Style Guide Adherence: Addressed minor stylistic issues to align with the documentation review style guide, focusing on clarity and sentence structure.
Merge Readiness
The changes in this pull request are necessary to accurately reflect the current capabilities of TiDB Cloud Serverless. The feedback provided is minor and aimed at improving clarity and adherence to the style guide. Once these suggestions are addressed, the pull request will be ready for merging. I am unable to approve this pull request, and users should have others review and approve this code before merging.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This is an automated cherry-pick of #20832
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?