cloud: information_schema should be performance_schema
#21011
Conversation
ti-chi-bot
bot
added
contribution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request to help everyone get up to speed quickly.
The primary intent of this PR, as indicated by the title, is to clean up the documentation related to migrating from MySQL to TiDB Cloud using Data Migration. Specifically, it addresses a minor typo or duplication in the list of system databases that are filtered out during the migration process. The change involves removing a redundant mention of the information_schema database from a sentence in the tidb-cloud/migrate-from-mysql-using-data-migration.md file.
Highlights
- Documentation Fix: This pull request fixes a small error in the documentation for migrating data to TiDB Cloud.
- Typo Removal: A duplicate mention of the
information_schemadatabase was removed from a list of filtered databases.
Changelog
- tidb-cloud/migrate-from-mysql-using-data-migration.md
- Removed a duplicate entry for
information_schemafrom the list of system databases that are filtered out during migration (line 31).
- Removed a duplicate entry for
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
hfxsd
added
translation/no-need
There was a problem hiding this comment.
Code Review
This pull request correctly removes a duplicate mention of information_schema in the documentation. This is a good catch and improves the clarity and conciseness of the text. The change aligns well with the style guide's emphasis on avoiding repetition.
Summary of Findings
- Documentation Clarity: A duplicate instance of
information_schemawas removed, enhancing the clarity and conciseness of the documentation. This aligns with best practices for technical writing.
Merge Readiness
The change is minor, correct, and improves the documentation. It appears ready to be merged. As per standard procedure, please ensure any other required reviews are completed before merging. I am not authorized to approve the pull request.
| ### Filtered out and deleted databases | ||
|
|
||
| - The system databases will be filtered out and not migrated to TiDB Cloud even if you select all of the databases to migrate. That is, `mysql`, `information_schema`, `information_schema`, and `sys` will not be migrated using this feature. | ||
| - The system databases will be filtered out and not migrated to TiDB Cloud even if you select all of the databases to migrate. That is, `mysql`, `information_schema`, and `sys` will not be migrated using this feature. |
There was a problem hiding this comment.
| - The system databases will be filtered out and not migrated to TiDB Cloud even if you select all of the databases to migrate. That is, `mysql`, `information_schema`, and `sys` will not be migrated using this feature. | |
| - The system databases will be filtered out and not migrated to TiDB Cloud even if you select all of the databases to migrate. That is, `mysql`, `information_schema`, `performance_schema` and `sys` will not be migrated using this feature. |
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hfxsd
changed the title
information_ _schema should be performance_schema
hfxsd
changed the title
information_ _schema should be performance_schemainformation_schema should be performance_schema
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hfxsd
added
the
needs-cherry-pick-release-cloud
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
hfxsd
added
cherry-pick-release-cloud/no-need
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?