tiflash: add scale.md doc #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran-huang
added
translation/from-docs-cn
ran-huang
commented
Apr 7, 2020
reference/tiflash/scale.md
Outdated
| > | ||
| > The offline process described in this section does not delete the data on the offline node. If you need to take the node online again, delete the data manually. | ||
|
|
||
| 1. Take the node to be scaled in offline. See [Take TiFlash nodes offline](/reference/tiflash/maintain.md#take-tiflash-nodes-offline) for details. |
Contributor
Author
There was a problem hiding this comment.
The reference anchor is not finalized since the translation of maintain.md is not finished yet.
Contributor
There was a problem hiding this comment.
@ran-huang The anchor is decided: #take-a-tiflash-node-down.
ilovesoup
approved these changes
Apr 7, 2020
Contributor
ilovesoup
left a comment
ilovesoup
left a comment
There was a problem hiding this comment.
This applies only to 3.1.
4.0 will have different content.
Contributor
The 4.0 changes might refer to pingcap/docs-cn#2641. |
TomShawn
reviewed
Apr 8, 2020
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Contributor
Author
|
@TomShawn PTAL again~ |
TomShawn
reviewed
Apr 8, 2020
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Contributor
Author
|
@TomShawn PTAL |
Contributor
|
I will merge this PR after #2189 is merged. |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 8, 2020
* tiflash: add scale.md doc * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update TOC.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * minor update * update anchor Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
5 tasks
Contributor
|
cherry pick to release-3.1 in PR #2209 |
Contributor
|
A dead link is introduced by this PR but it will be fixed by #2189 soon. |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 8, 2020
* tiflash: add scale.md doc * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update TOC.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * minor update * update anchor Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2210 |
yikeke
added a commit
that referenced
this pull request
Apr 8, 2020
* tiflash: add scale.md doc * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update TOC.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * minor update * update anchor Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
added a commit
that referenced
this pull request
Apr 8, 2020
* tiflash: add scale.md doc * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update TOC.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * minor update * update anchor Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add
scale.mddoc for TiFlash.Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?