cloud: essential public preview on AWS#21847
cloud: essential public preview on AWS#21847ti-chi-bot[bot] merged 18 commits intopingcap:release-8.5from
Conversation
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the public preview of the TiDB Cloud 'Essential' cluster tier on AWS into the existing documentation. The changes ensure that users are aware of the new offering, understand its architectural context, and can follow updated guides for connecting to these clusters, particularly via AWS PrivateLink. The updates provide comprehensive information for users looking to leverage the 'Essential' tier on AWS for their production-ready workloads. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect the public preview of TiDB Cloud Essential on AWS. The changes are mostly consistent and correct, adding information about the 'Essential' tier for AWS across multiple files. I have provided a couple of minor suggestions to improve textual consistency and conciseness for better readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@zuowei593: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - Connect to Your TiDB Cloud Cluster | ||
| - [Connection Overview](/tidb-cloud/connect-to-tidb-cluster-serverless.md) | ||
| - [Connect via Public Endpoint](/tidb-cloud/connect-via-standard-connection-serverless.md) | ||
| - [Connect via Private Endpoint with AWS](/tidb-cloud/set-up-private-endpoint-connections-serverless.md) |
There was a problem hiding this comment.
Note for reviewer:
We'll rename the set-up-private-endpoint-connections-serverless.md file to make it more appropriate in another PR. This file is not newly introduced in this PR.
Co-authored-by: Lilian Lee <lilin@pingcap.com>
There was a problem hiding this comment.
Doc preview link for this PR: https://pr.pingcap-docsite-preview.pages.dev/tidbcloud/essential/?plan=essential
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?