br: removed the sentence about the outdated restore speed#21859
br: removed the sentence about the outdated restore speed#21859ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
missing-translation-status
qiancai
added
area/br
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains a mix of unrelated changes. The title suggests a correction to the BR store speed, which is reflected in br/br-snapshot-guide.md. However, the PR also introduces a very large set of new Python scripts for a documentation translation workflow, changes a repository owner in a script to a personal username, and removes some feature documentation from system-variables.md. It's highly recommended to split these unrelated changes into separate pull requests for clarity and easier review. My feedback focuses on the specific changes in the diff.
qiancai
force-pushed
the
translate/#20973
branch
from
62df7e9 to
78c4089
Compare
ti-chi-bot
bot
added
the
size/XS
ti-chi-bot
bot
added
the
missing-translation-status
qiancai
added
translation/from-docs-cn
|
@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?