Skip to content

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Apr 7, 2020

What is changed, added or deleted? (Required)

  • Fix format of two notes that cause rendering failure in placement-rules.md
  • Add a body heading for sql-diagnosis.md because of too many contents at the beginning section

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@lilin90 lilin90 added size/small Changes of a small size. needs-cherry-pick-4.0 labels Apr 7, 2020
@lilin90 lilin90 requested a review from TomShawn April 7, 2020 09:57
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 1e458a5 into pingcap:master Apr 7, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 7, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

cherry pick to release-4.0 in PR #2187

@lilin90 lilin90 deleted the update-format branch April 7, 2020 10:00
TomShawn pushed a commit that referenced this pull request Apr 7, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants