Skip to content

statements: add privilege details (#21815)#21860

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-21815-to-release-8.1
Oct 9, 2025
Merged

statements: add privilege details (#21815)#21860
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-21815-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #21815

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

dveeden and others added 7 commits September 30, 2025 09:52
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. type/enhancement The issue or PR belongs to an enhancement. labels Sep 30, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2025
14 tasks
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity and completeness of the TiDB documentation by adding explicit privilege requirements for several key SQL statements and information schema views. It ensures users understand the necessary permissions for CREATE BINDING, SHOW PROCESSLIST, and INFORMATION_SCHEMA.CLUSTER_PROCESSLIST, and also clarifies how to view cluster-wide process information.

Highlights

  • Documentation for INFORMATION_SCHEMA.CLUSTER_PROCESSLIST: Added a new "Permissions" section, clarifying that users without the PROCESS privilege can only view their own sessions.
  • Documentation for CREATE BINDING statement: Introduced a "Permissions" section, specifying that the SUPER privilege is required for its execution.
  • Documentation for SHOW PROCESSLIST: Enhanced the documentation by adding a "Permissions" section, detailing that without the PROCESS privilege, only the user's own sessions are displayed.
  • Clarification for SHOW PROCESSLIST: Updated the SHOW PROCESSLIST overview to explicitly guide users to INFORMATION_SCHEMA.CLUSTER_PROCESSLIST for viewing cluster-wide process lists.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Permissions section to the documentation for PROCESSLIST, CREATE BINDING, and SHOW PROCESSLIST, clarifying the necessary privileges for these operations. It also adds a helpful cross-reference to the CLUSTER_PROCESSLIST table. My review focuses on aligning the new content with the documentation style guide. I've suggested minor wording changes to use the second person ("you") for a more direct address to the user and to improve conciseness, as recommended by the style guide.

Comment thread information-schema/information-schema-processlist.md
Comment thread sql-statements/sql-statement-create-binding.md
Comment thread sql-statements/sql-statement-show-processlist.md
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Oct 9, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 9, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 7875e3c into pingcap:release-8.1 Oct 9, 2025
9 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the cherry-pick-21815-to-release-8.1 branch October 9, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants