Skip to content

ticdc: clarify statements for DDLs (#21866)#21912

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-21866-to-release-8.5
Oct 15, 2025
Merged

ticdc: clarify statements for DDLs (#21866)#21912
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-21866-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #21866

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Sort the list
  • Link to statement docs
  • replace things that aren't statements with actual statements

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Oct 15, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for TiCDC's bidirectional replication by clarifying and organizing the lists of replicable and non-replicable DDL statements. The changes aim to improve user understanding and navigation by providing precise SQL syntax, direct links to detailed documentation for each statement, and alphabetically sorting the lists for better readability.

Highlights

  • Improved DDL Statement Clarity: The lists of replicable and non-replicable DDLs have been updated to use more precise SQL statement syntax, replacing generic descriptions with actual statement patterns (e.g., 'ADD COLUMN' changed to 'ALTER TABLE ... ADD COLUMN').
  • Enhanced Documentation Linking: Each DDL statement in the lists now includes a direct markdown link to its corresponding SQL statement documentation, making it easier for users to find detailed information.
  • List Sorting: Both the replicable and non-replicable DDL lists have been sorted alphabetically for better readability and easier navigation.
  • Minor Formatting Fixes: A small formatting issue in a code block example was corrected, and 'AUTO_INCREMENT' and 'AUTO_RANDOM' terms were linked to their documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the documentation for TiCDC bidirectional replication by clarifying the replicable and non-replicable DDL statements. The lists are now sorted, use more precise statement syntax, and include helpful links to the relevant SQL statement documentation. These changes make the document much clearer and easier for users to understand.

I've added a few suggestions to correct some incorrect links and improve consistency in the statement formatting. Once these minor issues are addressed, the documentation will be in great shape.

@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Oct 15, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9724df8 into pingcap:release-8.5 Oct 15, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-21866-to-release-8.5 branch October 15, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants