The calculation of raft-log-gc-count-limit should be based on 1 KiB #21966
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @King-Dylan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rectifies a minor but significant inaccuracy within the TiKV configuration documentation. It specifically corrects the unit used in the default value calculation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the calculation basis for raft-log-gc-count-limit from 1 MiB to 1 KiB. I have provided a minor suggestion to rephrase the description for better clarity and readability. The change is accurate and improves the documentation.
|
|
||
| + The hard limit on the allowable number of residual Raft logs | ||
| + Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1MiB for each log) | ||
| + Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1KiB for each log) |
There was a problem hiding this comment.
To improve readability, this sentence can be rephrased to be more direct.
| + Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1KiB for each log) | |
| + Default value: the number of logs that can fit into 3/4 of the Region size, calculated assuming each log is 1KiB |
1 participant
First-time contributors' checklist
close issue-21965
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?