Skip to content

The calculation of raft-log-gc-count-limit should be based on 1 KiB #21966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

The calculation of raft-log-gc-count-limit should be based on 1 KiB #21966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tikv-configuration-file.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@
### `raft-log-gc-count-limit`

+ The hard limit on the allowable number of residual Raft logs
+ Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1MiB for each log)
+ Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1KiB for each log)

Check failure on line 765 in tikv-configuration-file.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[PingCAP.Units] Put a nonbreaking space between the number and the unit in '1KiB'.

Raw Output:
{"message": "[PingCAP.Units] Put a nonbreaking space between the number and the unit in '1KiB'.", "location": {"path": "tikv-configuration-file.md", "range": {"start": {"line": 765, "column": 96}}}, "severity": "ERROR"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To improve readability, this sentence can be rephrased to be more direct.

Suggested change
+ Default value: the log number that can be accommodated in the 3/4 Region size (calculated as 1KiB for each log)
+ Default value: the number of logs that can fit into 3/4 of the Region size, calculated assuming each log is 1KiB

+ Minimum value: `0`

### `raft-log-gc-size-limit`
Expand Down