-
Notifications
You must be signed in to change notification settings - Fork 708
Do not merge until v8.5.4: doc updates for v8.5.4 #22063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request consolidates a comprehensive set of documentation updates for the upcoming TiDB v8.5.4 release. The changes introduce new SQL statements for fine-grained control over table Region distribution, enhance DDL operations by embedding automatic statistics collection for indexes, and improve compatibility with MySQL's DECIMAL behavior. Furthermore, the documentation for the Follower Read feature has been significantly refined, global indexes now support non-unique columns, and the new TiCDC architecture's monitoring is better integrated. These updates aim to provide users with clear, up-to-date information on new features and behavioral changes in the latest TiDB version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request includes documentation updates for TiDB v8.5.4. The changes cover new features like ANALYZE embedded in DDL, DISTRIBUTE TABLE, and new system variables. The documentation for Follower Read, partitioned tables, and TiCDC has also been significantly improved for clarity and accuracy.
Overall, the updates are well-written and provide valuable information for users. I have one minor suggestion for grafana-tidb-dashboard.md to ensure consistency in metric descriptions. The rest of the changes are excellent.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@hfxsd: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is changed, added or deleted? (Required)
This PR covers all doc updates for v8.5.4 that have been merge to the feature/preview-v8.5.4 branch.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?