Skip to content

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Nov 18, 2025

What is changed, added or deleted? (Required)

This PR covers all doc updates for v8.5.4 that have been merge to the feature/preview-v8.5.4 branch.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai self-assigned this Nov 18, 2025
@ti-chi-bot ti-chi-bot bot added the area/develop This PR relates to the area of TiDB App development. label Nov 18, 2025
@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed area/develop This PR relates to the area of TiDB App development. labels Nov 18, 2025
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request consolidates a comprehensive set of documentation updates for the upcoming TiDB v8.5.4 release. The changes introduce new SQL statements for fine-grained control over table Region distribution, enhance DDL operations by embedding automatic statistics collection for indexes, and improve compatibility with MySQL's DECIMAL behavior. Furthermore, the documentation for the Follower Read feature has been significantly refined, global indexes now support non-unique columns, and the new TiCDC architecture's monitoring is better integrated. These updates aim to provide users with clear, up-to-date information on new features and behavioral changes in the latest TiDB version.

Highlights

  • New DDL Statements for Region Distribution: Introduced DISTRIBUTE TABLE, CANCEL DISTRIBUTION JOB, SHOW DISTRIBUTION JOBS, and SHOW TABLE DISTRIBUTION statements to manage and monitor table Region distribution across TiFlash and TiKV nodes.
  • Embedded ANALYZE in DDL Statements: Added a new feature that automatically runs ANALYZE (statistics collection) during ADD INDEX, MODIFY COLUMN, and CHANGE COLUMN operations, ensuring prompt statistics updates for new or reorganized indexes and preventing suboptimal query plans. This is controlled by the new tidb_stats_update_during_ddl system variable.
  • MySQL Compatibility for DECIMAL: TiDB v8.5.4 now aligns its DECIMAL data type behavior with MySQL, automatically truncating extra decimal places during insertion, regardless of their count.
  • Enhanced Follower Read Documentation: Updated the Follower Read documentation with clearer usage scenarios, detailed replica selection strategies (leader, closest-replicas, closest-adaptive), performance overhead considerations, and new monitoring metrics in Grafana.
  • Global Indexes for Non-Unique Columns: Global indexes for partitioned tables now support non-unique indexes, expanding their utility beyond unique keys.
  • TiCDC New Architecture Monitoring Integration: The TiCDC-New-Arch monitoring dashboard is now integrated into Grafana for TiDB clusters v8.5.4 and later, simplifying monitoring setup.
  • New TiFlash Configuration: Added graceful_wait_shutdown_timeout for TiFlash, allowing configuration of the maximum wait time for unfinished MPP tasks during server shutdown.
  • New Optimizer System Variables: Introduced tidb_opt_enable_no_decorrelate_in_select and tidb_opt_enable_semi_join_rewrite system variables to control optimizer behavior for subqueries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Nov 18, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes documentation updates for TiDB v8.5.4. The changes cover new features like ANALYZE embedded in DDL, DISTRIBUTE TABLE, and new system variables. The documentation for Follower Read, partitioned tables, and TiCDC has also been significantly improved for clarity and accuracy.

Overall, the updates are well-written and provide valuable information for users. I have one minor suggestion for grafana-tidb-dashboard.md to ensure consistency in metric descriptions. The rest of the changes are excellent.

@ti-chi-bot ti-chi-bot bot added the area/develop This PR relates to the area of TiDB App development. label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-19 07:25:28.773385311 +0000 UTC m=+82892.422579768: ☑️ agreed by hfxsd.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2025

@hfxsd: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants