update the link for the Percolator and TiDB Transaction Algorithm blog#22118
update the link for the Percolator and TiDB Transaction Algorithm blog#22118ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating an outdated documentation link within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
the
missing-translation-status
ti-chi-bot
bot
added
the
size/XS
qiancai
added
translation/no-need
qiancai
changed the title
ti-chi-bot
bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a URL in faq/manage-cluster-faq.md that points to an article about the Percolator and TiDB Transaction Algorithm. The change itself seems correct. However, the pull request description is inconsistent with the changes. The description states that cn.pingcap.com links are being updated to pingkai.cn, but the actual change is from a pingcap.com/blog-cn/ URL to a tidb.net/blog/ URL. Please update the pull request description to accurately reflect the changes for better tracking and history.
| ### If Percolator uses distributed locks and the crash client keeps the lock, will the lock not be released? | ||
|
|
||
| For more details, see [Percolator and TiDB Transaction Algorithm](https://pingcap.com/blog-cn/percolator-and-txn/) in Chinese. | ||
| For more details, see [Percolator and TiDB Transaction Algorithm](https://tidb.net/blog/f537be2c) in Chinese. |
There was a problem hiding this comment.
For better readability1, it's common to put language indicators in parentheses.
| For more details, see [Percolator and TiDB Transaction Algorithm](https://tidb.net/blog/f537be2c) in Chinese. | |
| For more details, see [Percolator and TiDB Transaction Algorithm](https://tidb.net/blog/f537be2c) (in Chinese). |
Style Guide References
Footnotes
-
The style guide emphasizes clarity and readability. Using parentheses for metadata like the language of a link is a common convention that improves readability by separating it from the main sentence flow. ↩
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
added
needs-cherry-pick-release-5.4
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
3 participants
What is changed, added or deleted? (Required)
This PR updates cn.pingcap.com links to pingkai.cn links.
Reason: pingkai.cn will gradually replace cn.pingcap.com.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?