Skip to content

migrate-from-mariadb: add note about utf8mb4_uca1400_ai_ci#22133

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
dveeden:mariadb_uca1400
Dec 3, 2025
Merged

migrate-from-mariadb: add note about utf8mb4_uca1400_ai_ci#22133
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
dveeden:mariadb_uca1400

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Dec 2, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Dec 2, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TiDB documentation for users migrating from MariaDB by addressing a specific compatibility issue related to character set collations. It provides essential guidance on how to handle the utf8mb4_uca1400_ai_ci collation, which is not supported in TiDB, ensuring a smoother migration process.

Highlights

  • Documentation Update: Added a crucial note to the MariaDB migration guide, informing users about TiDB's lack of support for the utf8mb4_uca1400_ai_ci collation, which is now the default in MariaDB. The documentation now recommends replacing it with utf8mb4_0900_ai_ci and clarifies the difference in UCA standard versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful note about the utf8mb4_uca1400_ai_ci collation not being supported in TiDB. I've suggested a few minor wording changes to align with the documentation style guide, focusing on clarity and avoiding contractions and passive voice. Overall, this is a good addition to the documentation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd hfxsd self-assigned this Dec 2, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Dec 2, 2025
@hfxsd hfxsd changed the title migrate-from-mariadb: Add note about utf8mb4_uca1400_ai_ci migrate-from-mariadb: add note about utf8mb4_uca1400_ai_ci Dec 2, 2025
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Dec 2, 2025

@hfxsd should we link to charset docs?

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-02 12:08:21.405532841 +0000 UTC m=+351646.219310423: ☑️ agreed by hfxsd.
  • 2025-12-02 12:08:23.199302674 +0000 UTC m=+351648.013080246: ☑️ agreed by hfxsd.

@hfxsd hfxsd requested a review from Oreoxmt December 2, 2025 12:29
Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Dec 3, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit ab81f3c into pingcap:master Dec 3, 2025
9 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants