Skip to content

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Dec 3, 2025

What is changed, added or deleted? (Required)

Replaced <li> tags with <ul><li>...</li></ul> for table cell lists in oracle-functions-to-tidb.md and releases/release-8.5.0.md to fix the issue that the HTML list symbols in complex tables are displayed too close to the border.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Dec 3, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily introduces a new file, temp.md, containing a simple test string. While the PR description indicates an intent to resolve <li> formatting issues within tables in specific documentation files, the provided patch only reflects the addition of this new test file.

Highlights

  • New File Added: A new file named temp.md has been introduced to the repository.
  • File Content: The temp.md file contains the simple string: "This is a test file.".
  • Discrepancy with Description: The pull request description mentions fixing <li> formatting in oracle-functions-to-tidb.md and releases/release-8.5.0.md, but these changes are not reflected in the provided patch, which only shows the addition of temp.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request's title and description indicate a fix for list formatting in tables. However, the actual change is the addition of a new file temp.md. The intended changes described in the PR description seem to be missing. Please verify that the correct changes have been committed to this pull request. I have also left one minor suggestion for the new file.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2025
@qiancai qiancai changed the title fix <li> formatting in tables fix <li> formatting in tables Dec 3, 2025
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 3, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 3, 2025

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt December 3, 2025 03:35
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Dec 3, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-03 06:32:09.183075783 +0000 UTC m=+417873.996853355: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 3, 2025

/approve

@qiancai qiancai added the lgtm label Dec 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit a976f53 into pingcap:master Dec 3, 2025
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22141.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants