Skip to content

Conversation

@ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Update TiFlash scale doc for the latest TiDB version.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Apr 9, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ran-huang and others added 2 commits April 9, 2020 15:40
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

Your auto merge job has been accepted, waiting for 2227, 2228

@yikeke yikeke merged commit 5451d23 into pingcap:master Apr 9, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 9, 2020
* tiflash: update scale doc for 4.0

* fix code block

* Apply suggestions from code review

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update reference/tiflash/scale.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

cherry pick to release-4.0 in PR #2229

@ran-huang ran-huang deleted the tiflash-scale-4.0 branch April 9, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants