-
Notifications
You must be signed in to change notification settings - Fork 708
Add duplicate button feature. #22173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ginkgoch. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary of ChangesHello @ginkgoch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user documentation for TiDB Cloud by introducing a guide for a new "duplicate changefeed" feature. The addition aims to provide clear instructions for users who wish to replicate existing changefeed configurations, streamlining their workflow and improving the overall usability of the platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the new 'Duplicate a changefeed' feature. The changes are clear and follow the existing document structure. I've suggested a minor wording improvement to enhance clarity and conciseness, aligning with the repository's style guide.
| 3. TiDB Cloud auto-populates the new changefeed configuration using the original settings. Review and modify configurations as necessary for your new task. | ||
| 4. Once you have confirmed the configurations are correct, click **Submit** to create and start the new changefeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity and conciseness, and to better align with the style guide's preference for addressing the user in the second person ("you"), I suggest a few wording improvements for these steps. This follows the principles of clarity (line 14), writing in the second person (line 22), and avoiding unnecessary words (line 24) from the repository style guide.
| 3. TiDB Cloud auto-populates the new changefeed configuration using the original settings. Review and modify configurations as necessary for your new task. | |
| 4. Once you have confirmed the configurations are correct, click **Submit** to create and start the new changefeed. | |
| 3. TiDB Cloud automatically populates the new changefeed configuration with the original settings. You can review and modify the configuration as needed. | |
| 4. After confirming the configuration, click **Submit** to create and start the new changefeed. |
zoubingwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@zoubingwu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add duplicate support for a changefeed.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?