upgrade: replace the wrong command SELECT TIDB_CURRENT_TSO() with BEGIN; SELECT TIDB_CURRENT_TSO(); ROLLBACK; (#22203)#22206
Conversation
ti-chi-bot
added
lgtm
type/cherry-pick-for-release-8.5
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accuracy of the TiDB upgrade migration guide by correcting a critical SQL command. The change ensures that users retrieve the current Timestamp Oracle (TSO) using the proper transactional context, which is vital for maintaining data consistency and successful replication during cluster upgrades. This update improves the reliability of the documentation and helps prevent potential issues arising from incorrect TSO retrieval. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the command for retrieving the current TSO in the upgrade migration guide. It correctly replaces SELECT tidb_current_ts() with BEGIN; SELECT TIDB_CURRENT_TSO(); ROLLBACK; to ensure a fresh timestamp is retrieved within a new transaction. Note that there is a small discrepancy between the PR title, which mentions SELECT TIDB_CURRENT_TSO() as the old command, and the actual change from SELECT tidb_current_ts(). My review focuses on improving the readability of the new SQL command in the documentation. I've suggested splitting the single-line command into multiple lines to enhance clarity, which is in line with the documentation style guide.
|
/approve |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
This is an automated cherry-pick of #22203
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
SELECT TIDB_CURRENT_TSO()withBEGIN; SELECT TIDB_CURRENT_TSO(); ROLLBACK;docs-cn#21201Do your changes match any of the following descriptions?