Skip to content

cloud: delete oss:ListBuckets permission for Alibaba Cloud#22207

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
hfxsd:delete-oss-ListBuckets
Dec 19, 2025
Merged

cloud: delete oss:ListBuckets permission for Alibaba Cloud#22207
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
hfxsd:delete-oss-ListBuckets

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Dec 19, 2025

Removed the requirement for the oss:ListBuckets permission when exporting data to Alibaba Cloud OSS in both configuration and serverless export documentation. Only oss:PutObject and oss:GetBucketInfo are now required.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Removed the requirement for the oss:ListBuckets permission when exporting data to Alibaba Cloud OSS in both configuration and serverless export documentation. Only oss:PutObject and oss:GetBucketInfo are now required.
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Dec 19, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation related to Alibaba Cloud OSS integration for TiDB Cloud, specifically updating the required permissions for data export. The primary goal is to simplify and clarify the necessary access credentials, ensuring users grant only the essential permissions for secure and efficient data operations.

Highlights

  • Alibaba Cloud OSS Permissions Update: The documentation has been updated to remove the oss:ListBuckets permission requirement for exporting data to Alibaba Cloud OSS. This change applies to both general configuration and serverless export documentation.
  • Simplified Export Permissions: For data export to Alibaba Cloud OSS, only oss:PutObject and oss:GetBucketInfo permissions are now explicitly required, streamlining the access credential setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hfxsd hfxsd changed the title cloud: delete oss:ListBuckets permission for Alibaba Cloud cloud: delete oss:ListBuckets permission for Alibaba Cloud Dec 19, 2025
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2025
@hfxsd hfxsd requested a review from shiyuhang0 December 19, 2025 02:30
@hfxsd hfxsd self-assigned this Dec 19, 2025
@hfxsd hfxsd added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. contribution This PR is from a community contributor. labels Dec 19, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the oss:ListBuckets permission requirement for exporting data to Alibaba Cloud OSS, updating the documentation in two files. The changes are correct. I've provided a couple of suggestions to improve documentation style and consistency, such as using backticks for permissions as per the style guide and improving conciseness.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 19, 2025

@shiyuhang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Dec 19, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Dec 19, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit d373c7f into pingcap:release-8.5 Dec 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants