add restore from s3/oss#22208
Conversation
Summary of ChangesHello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces essential documentation for TiDB Cloud Premium users, enabling them to restore backups directly from cloud object storage providers like AWS S3 and Alibaba Cloud OSS. The changes include detailed prerequisites and step-by-step instructions for this new restoration capability, alongside minor terminology adjustments to improve clarity and broaden the scope of backup types discussed in the documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
missing-translation-status
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for restoring backups from cloud storage like S3 or OSS. The changes are generally good, but I've provided several suggestions to improve formatting, clarity, and adherence to the documentation style guide. My feedback includes using sentence case for headings, using backticks for UI elements as per the style guide, improving the structure of a procedural step, and correcting the format of a note block while removing redundant information.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@grovecai: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hfxsd
added
translation/no-need
Clarified and updated instructions for restoring backups from cloud storage, including revised authentication fields and step order. Added details about regional high availability for premium instances and adjusted step numbering for instance creation.
|
@qqqdan: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Moved and consolidated limitations for restoring backups to a dedicated section before the steps. Clarified supported cloud providers, manual backup support, and cross-region fees. Updated prerequisites to focus on required credentials.
Co-authored-by: Grace Cai <qqzczy@126.com>
Expanded documentation links to reference 'Premium' alongside 'Starter' and 'Essential' in high availability sections for clarity and completeness.
Standardized references to high availability documentation in TiDB Cloud by updating link text in architecture-concepts.md and key-concepts.md. Added a note in serverless-high-availability.md to direct users to the dedicated high availability documentation for TiDB Cloud Dedicated.
Co-authored-by: Grace Cai <qqzczy@126.com>
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
hfxsd
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add manual content for restore from s3/oss
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?