-
Notifications
You must be signed in to change notification settings - Fork 709
cloud: update backup policies and execution rules #22227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Clarified and updated instructions for restoring backups from cloud storage, including revised authentication fields and step order. Added details about regional high availability for premium instances and adjusted step numbering for instance creation.
Moved and consolidated limitations for restoring backups to a dedicated section before the steps. Clarified supported cloud providers, manual backup support, and cross-region fees. Updated prerequisites to focus on required credentials.
Co-authored-by: Grace Cai <qqzczy@126.com>
Expanded documentation links to reference 'Premium' alongside 'Starter' and 'Essential' in high availability sections for clarity and completeness.
Standardized references to high availability documentation in TiDB Cloud by updating link text in architecture-concepts.md and key-concepts.md. Added a note in serverless-high-availability.md to direct users to the dedicated high availability documentation for TiDB Cloud Dedicated.
Co-authored-by: Grace Cai <qqzczy@126.com>
Summary of ChangesHello @wildpcww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for TiDB Cloud, primarily focusing on the automatic backup behavior and high availability configurations for the Premium tier. The changes reflect a new tier design for backups, providing more detailed information on backup policies and introducing the ability to restore from external cloud storage. Additionally, the documentation now clearly states the default and non-configurable regional high availability setting for Premium instances. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation to reflect new backup and high availability designs, primarily for the Premium tier. The changes are generally clear and align with the new features. My review includes suggestions to fix typos in custom markdown tags, improve phrasing for consistency with the style guide, and reduce repetition for better maintainability. Overall, the updates are good, and my feedback aims to polish the content further.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@grovecai: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Modified autobackup behavior to reflect the new tier design.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?