Hibernate: recommend MySQLDialect over TiDBDialect (#22193)#22231
Conversation
- Update dialect recommendation from TiDBDialect to MySQLDialect - Add link to TiDBDialect in Hibernate community dialects for users who need it - Add guidance for reporting compatibility issues Closes pingcap#21618
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Add an extensible "Compatibility notes for MySQLDialect" section to document behavioral differences when using MySQLDialect with TiDB. Initial content covers SERIALIZABLE isolation level handling and the tidb_skip_isolation_level_check workaround.
Co-authored-by: Grace Cai <qqzczy@126.com>
ti-chi-bot
added
area/develop
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Hibernate documentation to guide users towards using Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Hibernate documentation to recommend MySQLDialect over TiDBDialect, which is a sensible change given the maintenance status of TiDBDialect. The changes are clear and provide good context for users, including a new section on compatibility with MySQLDialect. I've provided a few suggestions to improve wording and fix a minor typo, aligning the text more closely with the repository's style guide by using a more direct tone and active voice.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This is an automated cherry-pick of #22193
What is changed, added or deleted? (Required)
Closes #21618
This PR updates the Hibernate documentation to recommend
MySQLDialectoverTiDBDialect.Background: Starting with Hibernate 7.x,
TiDBDialectwas moved from hibernate-core to hibernate-community-dialects (HHH-19361). Since PingCAP has no current maintenance plan for the community dialect, and TiDB is highly MySQL-compatible, usingMySQLDialectis the recommended approach for long-term compatibility.Changes:
org.hibernate.dialect.TiDBDialecttoorg.hibernate.dialect.MySQLDialectorg.hibernate.community.dialect.TiDBDialectin Hibernate community dialects for users who need itWhich TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?