Skip to content

add tooltip-terms.json#22620

Merged
qiancai merged 4 commits into
pingcap:masterfrom
qiancai:add-tooltip-terms
Mar 26, 2026
Merged

add tooltip-terms.json#22620
qiancai merged 4 commits into
pingcap:masterfrom
qiancai:add-tooltip-terms

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Mar 24, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add tooltip-terms.json, which includes the term definitions in English, Chinese, and Japanese.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new JSON file, tooltip-terms.json, to standardize and centralize the definitions of important terms related to TiDB Cloud features. This initiative aims to improve consistency and facilitate multilingual support by providing definitions in English, Chinese, and Japanese, ensuring that key concepts like "data-branch" and "sql-editor" are clearly understood across different linguistic contexts.

Highlights

  • New Term Definitions File: Introduced tooltip-terms.json to centralize definitions for key TiDB Cloud terms.
  • Multilingual Support: Definitions are provided in English, Chinese, and Japanese for improved internationalization.
  • Initial Terms: Included initial definitions for "data-branch" and "sql-editor".

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a tooltip-terms.json file containing definitions for 'data-branch' and 'sql-editor' in English, Chinese, and Japanese. My review of the English definitions found them to be mostly clear and aligned with the documentation style guide. I have provided one suggestion to improve the clarity of the 'data-branch' definition by using simpler language, making it more accessible for all users.

Comment thread tooltip-terms.json Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread tooltip-terms.json Outdated
Comment thread tooltip-terms.json Outdated
@qiancai qiancai self-assigned this Mar 26, 2026
@qiancai qiancai added the cherry-pick-release-cloud/no-need No need to cherry pick this PR to the "release-cloud" branch. label Mar 26, 2026
@yahonda
Copy link
Copy Markdown
Member

yahonda commented Mar 26, 2026

Japanese translation looks good.

1 similar comment
@yahonda
Copy link
Copy Markdown
Member

yahonda commented Mar 26, 2026

Japanese translation looks good.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 26, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-26 05:39:26.517948207 +0000 UTC m=+419562.554018457: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 26, 2026
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Mar 26, 2026

/approve

@qiancai qiancai added the lgtm label Mar 26, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Mar 26, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed cherry-pick-release-cloud/no-need No need to cherry pick this PR to the "release-cloud" branch. labels Mar 26, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Mar 26, 2026
@qiancai qiancai merged commit 78fc621 into pingcap:master Mar 26, 2026
12 checks passed
@qiancai qiancai deleted the add-tooltip-terms branch March 26, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants