Skip to content

sync-diff-inspector: update versions to include v8.5.6#22663

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hfxsd:sync-diff-inspector-8.5.6
Mar 31, 2026
Merged

sync-diff-inspector: update versions to include v8.5.6#22663
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hfxsd:sync-diff-inspector-8.5.6

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Mar 31, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Mar 31, 2026
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Mar 31, 2026
@hfxsd hfxsd requested a review from Oreoxmt March 31, 2026 06:40
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2026
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2026
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TiDB Toolkit and sync-diff-inspector documentation to include TiDB v8.5.6 in the versions supported by TiUP and the tiflow package. Reviewers identified logical errors in the version range descriptions, noting that the proposed 'before v8.5.6 or v9.0.0' phrasing would incorrectly categorize versions like v8.5.7 as legacy. Suggestions were provided to clarify branch-specific versioning and ensure users are directed to the correct installation methods.

Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed translation/no-need No need to translate this PR. labels Mar 31, 2026
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 31, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 31, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-31 06:50:26.212196549 +0000 UTC m=+247831.417556606: ☑️ agreed by Oreoxmt.

github-actions bot added a commit to hfxsd/docs-cn that referenced this pull request Mar 31, 2026
Synced from: pingcap/docs#22663
Target PR: pingcap#21487
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. lgtm and removed translation/doing This PR's assignee is translating this PR. labels Mar 31, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Mar 31, 2026

/retest

@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Mar 31, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 31, 2026
@ti-chi-bot ti-chi-bot bot merged commit 96771f0 into pingcap:master Mar 31, 2026
12 checks passed
hfxsd added a commit to hfxsd/docs that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants