Skip to content

*: convert remaining sequence diagrams from PNG to Mermaid#22708

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
kennytm:mermaidify-sequence-diagrams
May 19, 2026
Merged

*: convert remaining sequence diagrams from PNG to Mermaid#22708
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
kennytm:mermaidify-sequence-diagrams

Conversation

@kennytm
Copy link
Copy Markdown
Contributor

@kennytm kennytm commented Apr 7, 2026

What is changed, added or deleted? (Required)

The remaining images which are obviously sequence diagrams are converted to mermaid. Totally 8 images are found from 4 pages.

  • br/br-log-architecture.md ("BR log backup process design" & "Point-in-time recovery process design")
  • br/br-snapshot-architecture.md ("snapshot backup process design" & "snapshot restore process design")
  • dm/feature-shard-merge-pessimistic.md ("shard-ddl-flow")
  • pessimistic-transaction.md ("TiDB pessimistic transaction commit process" & "Pessimistic transactions in TiDB" & "Pipelined pessimistic lock")

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@kennytm kennytm added area/transaction Indicates that the Issue or PR belongs to the area of transaction. area/dm area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). labels Apr 7, 2026
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces static images with Mermaid sequence diagrams in the documentation for BR log backup, snapshot backup and restore, DM pessimistic shard merging, and pessimistic transactions. These changes improve the maintainability of the architectural diagrams. I have no feedback to provide.

@kennytm kennytm mentioned this pull request Apr 7, 2026
@Oreoxmt Oreoxmt self-assigned this Apr 14, 2026
@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 14, 2026
@Oreoxmt Oreoxmt self-requested a review April 14, 2026 08:28
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Apr 14, 2026
Comment thread br/br-log-architecture.md Outdated
Comment thread br/br-snapshot-architecture.md Outdated
Comment thread br/br-snapshot-architecture.md Outdated
Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
Comment thread pessimistic-transaction.md Outdated
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 18, 2026
Co-authored-by: Aolin <aolinz@outlook.com>
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread pessimistic-transaction.md Outdated
Comment thread br/br-log-architecture.md Outdated
Comment thread br/br-log-architecture.md Outdated
Comment thread br/br-log-architecture.md Outdated
Comment thread br/br-snapshot-architecture.md Outdated
Comment thread br/br-snapshot-architecture.md Outdated
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 19, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-18 03:31:10.241190709 +0000 UTC m=+148599.745321375: ☑️ agreed by Oreoxmt.
  • 2026-05-19 03:17:15.544036225 +0000 UTC m=+234165.048166901: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented May 19, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 19, 2026
@ti-chi-bot ti-chi-bot Bot merged commit fcd07e8 into pingcap:master May 19, 2026
12 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22906.

@kennytm kennytm deleted the mermaidify-sequence-diagrams branch May 19, 2026 04:41
github-actions Bot added a commit to Oreoxmt/docs-cn that referenced this pull request May 19, 2026
Synced from: pingcap/docs#22708
Target PR: pingcap#21649
AI Provider: azure

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 19, 2026
github-actions Bot added a commit to Oreoxmt/docs-cn that referenced this pull request May 22, 2026
Synced from: pingcap/docs#22708
Target PR: pingcap#21649
AI Provider: azure

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). area/dm area/transaction Indicates that the Issue or PR belongs to the area of transaction. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants