v8.5.6 release notes: add info about cluster_id #22766
v8.5.6 release notes: add info about cluster_id #22766qiancai wants to merge 2 commits intopingcap:masterfrom
cluster_id #22766Conversation
qiancai
added
the
translation/from-docs-cn
ti-chi-bot
bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new file temp.md containing placeholder text. The review feedback correctly identifies a violation of the documentation style guide regarding the missing top-level heading and notes that the content does not align with the intended release notes for TiDB 8.5.6, providing a specific suggestion to address these issues.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
The file lacks a top-level heading, which violates the documentation style guide (MD041). Additionally, the file name temp.md and the content "This is a test file." appear to be placeholders and do not match the pull request title's intent to add information about cluster_id for the v8.5.6 release notes.
# TiDB 8.5.6 release notes
This release adds information about cluster_id.
References
- The first line of a Markdown file should be a top-level heading. (link)
Synced from: pingcap/docs-cn#21559 Target PR: pingcap#22766 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Auto-sync completed successfully Source PR: pingcap/docs-cn#21559 English documentation has been updated based on Chinese documentation changes. |
github-actions
bot
force-pushed
the
add-cluster_id-to-rn-21559
branch
from
a7ca30e to
b3c3e77
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
qiancai
added
the
needs-cherry-pick-release-8.5
|
@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
cluster_iddocs-cn#21559Do your changes match any of the following descriptions?