Skip to content

cloud: add steps for creating private endpoints on Google Cloud and Azure#22800

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.5from
hfxsd:add-console-steps-for-google-cloud
Apr 24, 2026
Merged

cloud: add steps for creating private endpoints on Google Cloud and Azure#22800
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.5from
hfxsd:add-console-steps-for-google-cloud

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Apr 24, 2026

…9546)

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for setting up private endpoint connections on Google Cloud by introducing a tabbed interface that provides instructions for both the Google Cloud CLI and the Google Cloud console. The review feedback suggests several refinements to improve clarity, conciseness, and consistency, such as using active voice, removing redundant words like "by" and "then", and ensuring consistent capitalization and terminology throughout the steps.

Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
@hfxsd hfxsd self-assigned this Apr 24, 2026
@hfxsd hfxsd added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Apr 24, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2026
@hfxsd hfxsd changed the title cloud: add console steps for Connect to a TiDB Cloud Dedicated Cluster via Google Cloud Private Service Connect cloud: add steps for creating private endpoints on Google Cloud and Azure Apr 24, 2026
Copy link
Copy Markdown

@xboxeer xboxeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 24, 2026

@xboxeer: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Looks good to me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested review from qiancai and yiduoyunQ April 24, 2026 08:01
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

Comment thread tidb-cloud/set-up-private-endpoint-connections-on-azure.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-azure.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-azure.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 24, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 24, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-24 09:31:26.126946905 +0000 UTC m=+2331091.332306962: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd added the lgtm label Apr 24, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 24, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 24, 2026
@ti-chi-bot ti-chi-bot Bot merged commit bb4644f into pingcap:release-8.5 Apr 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants