Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 16, 2020

What is changed, added or deleted? (Required)

Add a description of max-index-length.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. needs-cherry-pick-3.0 labels Apr 16, 2020
@TomShawn TomShawn requested review from ran-huang and zimulala April 16, 2020 12:13
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Apr 16, 2020
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Apr 18, 2020

@ran-huang, @zimulala, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

@ran-huang, @zimulala, PTAL.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang removed the status/PTAL This PR is ready for reviewing. label Apr 21, 2020
@ran-huang
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot sre-bot merged commit 34f61a6 into pingcap:master Apr 21, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-3.0 in PR #2352

@TomShawn TomShawn deleted the max-index-length branch April 21, 2020 02:12
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-3.1 in PR #2353

@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2020

cherry pick to release-4.0 in PR #2354

ran-huang pushed a commit that referenced this pull request Apr 21, 2020
* cherry pick #2303 to release-3.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <1135243111@qq.com>
ran-huang pushed a commit that referenced this pull request Apr 21, 2020
* cherry pick #2303 to release-3.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <1135243111@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants