Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 22, 2020

What is changed, added or deleted? (Required)

add description in tiup upgrade doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Apr 22, 2020
@TomShawn TomShawn requested review from kissmydb and yikeke April 22, 2020 08:08
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Apr 22, 2020
@yikeke yikeke requested a review from superlzs0476 April 24, 2020 02:32
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL This PR is ready for reviewing. labels Apr 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6ddf0f4 into pingcap:master Apr 24, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2020

cherry pick to release-4.0 in PR #2393

@TomShawn TomShawn deleted the tiup-upgrade-desc branch April 24, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants