Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented May 14, 2020

What is changed, added or deleted? (Required)

Add the Key Visualizer document.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. status/WIP This PR is still working in progress. needs-cherry-pick-4.0 labels May 14, 2020
@TomShawn TomShawn requested review from HunDunDM and yikeke May 25, 2020 02:54
@TomShawn TomShawn added v4.0 This PR/issue applies to TiDB v4.0. and removed status/WIP This PR is still working in progress. labels May 25, 2020
Copy link
Contributor

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

From the interface above, you can see the following objects:

+ A large heatmap that shows changes of the overall traffic over time.
+ The detailed information of heatmap axises.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the information of a certain coordinate point, not the coordinate axis.

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
TomShawn and others added 2 commits May 28, 2020 15:29
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented May 28, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2020
@yikeke yikeke merged commit a631e53 into pingcap:master May 28, 2020
@yikeke
Copy link
Contributor

yikeke commented May 28, 2020

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

cherry pick to release-4.0 in PR #2628

yikeke pushed a commit that referenced this pull request May 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the keyviz-d branch June 10, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants