-
Notifications
You must be signed in to change notification settings - Fork 708
Remove upgrade-tiflash.md #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Duplicated with TiDB's upgrade manual.
|
Do you need to add the TiFlash upgrade operations to TiDB's upgrade manual in this PR? And please remove the link in TOC.md to fix CI. |
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Confirmed. No need. |
|
You can directly delete the dead link in TOC to pass CI. @flowbehappy |
|
Should pass lint when #2603 got merged. |
zanmato1984
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update command line flags for pd configruation (#2596) Signed-off-by: nolouch <nolouch@gmail.com> * Remove upgrade-tiflash.md (#2597) * Remove upgrade-tiflash.md Duplicated with TiDB's upgrade manual. * delete a link Co-authored-by: yikeke <yikeke@pingcap.com> * Move TiFlash troubleshoot part to a new document (#2602) * best-practice: update massive regions to match 4.0 (#2595) Signed-off-by: Jay Lee <BusyJayLee@gmail.com> * sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] (#2618) Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: lei yu <leiysky@outlook.com> Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com>
* Update command line flags for pd configruation (#2596) Signed-off-by: nolouch <nolouch@gmail.com> * Remove upgrade-tiflash.md (#2597) * Remove upgrade-tiflash.md Duplicated with TiDB's upgrade manual. * delete a link Co-authored-by: yikeke <yikeke@pingcap.com> * add Coprocessor cache doc * Update coprocessor-cache.md * Update tidb-configuration-file.md * Apply suggestions from code review Co-authored-by: Wenxuan <hi@breeswish.org> * Update tidb-configuration-file.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
* Update command line flags for pd configruation (pingcap#2596) Signed-off-by: nolouch <nolouch@gmail.com> * Remove upgrade-tiflash.md (pingcap#2597) * Remove upgrade-tiflash.md Duplicated with TiDB's upgrade manual. * delete a link Co-authored-by: yikeke <yikeke@pingcap.com> * add Coprocessor cache doc * Update coprocessor-cache.md * Update tidb-configuration-file.md * Apply suggestions from code review Co-authored-by: Wenxuan <hi@breeswish.org> * Update tidb-configuration-file.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
* Update command line flags for pd configruation (#2596) Signed-off-by: nolouch <nolouch@gmail.com> * Remove upgrade-tiflash.md (#2597) * Remove upgrade-tiflash.md Duplicated with TiDB's upgrade manual. * delete a link Co-authored-by: yikeke <yikeke@pingcap.com> * add Coprocessor cache doc * Update coprocessor-cache.md * Update tidb-configuration-file.md * Apply suggestions from code review Co-authored-by: Wenxuan <hi@breeswish.org> * Update tidb-configuration-file.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Flowyi <flowbehappy@gmail.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Duplicated with TiDB's upgrade manual.
What is changed, added or deleted? (Required)
Remove upgrade-tiflash.md
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?