Skip to content

Conversation

@flowbehappy
Copy link
Contributor

Duplicated with TiDB's upgrade manual.

What is changed, added or deleted? (Required)

Remove upgrade-tiflash.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Duplicated with TiDB's upgrade manual.
@sre-bot sre-bot added special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 20, 2020
@sre-bot sre-bot requested review from kissmydb and lilin90 May 20, 2020 07:10
@TomShawn TomShawn requested a review from ilovesoup May 20, 2020 07:11
@yikeke yikeke requested review from yikeke and removed request for lilin90 May 20, 2020 07:18
@TomShawn TomShawn added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label May 20, 2020
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label May 20, 2020
@sre-bot sre-bot added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label May 21, 2020
@sre-bot sre-bot requested a review from miaoqingli May 21, 2020 03:44
@yikeke
Copy link
Contributor

yikeke commented May 21, 2020

Do you need to add the TiFlash upgrade operations to TiDB's upgrade manual in this PR?

And please remove the link in TOC.md to fix CI.
@flowbehappy

@yikeke yikeke requested review from zanmato1984 and removed request for miaoqingli May 21, 2020 05:12
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label May 21, 2020
@sre-bot sre-bot added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label May 21, 2020
@sre-bot sre-bot requested a review from lilin90 May 21, 2020 05:36
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented May 21, 2020

Do you need to add the TiFlash upgrade operations to TiDB's upgrade manual in this PR?

And please remove the link in TOC.md to fix CI.
@flowbehappy

Confirmed. No need.

@yikeke
Copy link
Contributor

yikeke commented May 21, 2020

You can directly delete the dead link in TOC to pass CI. @flowbehappy

@zanmato1984
Copy link
Contributor

Should pass lint when #2603 got merged.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit e2ab2ec into docs-special-week May 21, 2020
@yikeke yikeke deleted the remove-upgrade-tiflash branch May 21, 2020 07:56
@yikeke yikeke mentioned this pull request May 21, 2020
5 tasks
yikeke added a commit that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* Move TiFlash troubleshoot part to a new document (#2602)

* best-practice: update massive regions to match 4.0 (#2595)

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

* sql-statements: document BACKUP, RESTORE and SHOW [BACKUPS|RESTORES] (#2618)

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: lei yu <leiysky@outlook.com>
Co-authored-by: Jay <BusyJay@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
yikeke added a commit that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* add Coprocessor cache doc

* Update coprocessor-cache.md

* Update tidb-configuration-file.md

* Apply suggestions from code review

Co-authored-by: Wenxuan <hi@breeswish.org>

* Update tidb-configuration-file.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (pingcap#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (pingcap#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* add Coprocessor cache doc

* Update coprocessor-cache.md

* Update tidb-configuration-file.md

* Apply suggestions from code review

Co-authored-by: Wenxuan <hi@breeswish.org>

* Update tidb-configuration-file.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
TomShawn added a commit that referenced this pull request May 28, 2020
* Update command line flags for pd configruation (#2596)

Signed-off-by: nolouch <nolouch@gmail.com>

* Remove upgrade-tiflash.md (#2597)

* Remove upgrade-tiflash.md

Duplicated with TiDB's upgrade manual.

* delete a link

Co-authored-by: yikeke <yikeke@pingcap.com>

* add Coprocessor cache doc

* Update coprocessor-cache.md

* Update tidb-configuration-file.md

* Apply suggestions from code review

Co-authored-by: Wenxuan <hi@breeswish.org>

* Update tidb-configuration-file.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants