Skip to content

Conversation

@hsqlu
Copy link
Contributor

@hsqlu hsqlu commented May 20, 2020

Signed-off-by: Qiannan Lyu lvqiannan@gmail.com

What is changed, added or deleted? (Required)

Changed the default value of tmp-storage-path.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 20, 2020
@CLAassistant
Copy link

CLAassistant commented May 20, 2020

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. labels May 20, 2020
@TomShawn TomShawn requested review from SunRunAway and TomShawn May 20, 2020 12:13
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2020

@SunRunAway, @TomShawn, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2020

@SunRunAway, @TomShawn, PTAL.

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

@SunRunAway, @TomShawn, PTAL.

@TomShawn TomShawn added status/LGT2 Indicates that a PR has LGTM 2. and removed status/PTAL This PR is ready for reviewing. labels May 28, 2020
@yikeke
Copy link
Contributor

yikeke commented May 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

Your auto merge job has been accepted, waiting for:

  • 2410

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit d352c22 into pingcap:master May 29, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 29, 2020
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

cherry pick to release-4.0 in PR #2637

sre-bot added a commit that referenced this pull request May 29, 2020
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
@TomShawn TomShawn self-requested a review May 31, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants