Skip to content

Update Go requirements #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2020
Merged

Update Go requirements #2600

merged 4 commits into from
May 29, 2020

Conversation

@letientai299
Copy link
Contributor

@letientai299 letientai299 commented May 20, 2020

What is changed, added or deleted? (Required)

I've tried to build tidb locally using go 1.12 and fail with following error

# github.com/pingcap/tidb/store/tikv
store/tikv/2pc.go:765:69: time.Since(lockWaitStartTime).Milliseconds undefined (type time.Duration has no field or method Milliseconds)
store/tikv/2pc.go:838:37: time.Since(lockWaitStartTime).Milliseconds undefined (type time.Duration has no field or method Milliseconds)
note: module requires Go 1.13

It builds ok with Go 1.13+, so I think it's better to update those instruction that refer to Go 1.9 or later.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 20, 2020
@CLAassistant
Copy link

CLAassistant commented May 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested review from TomShawn and nolouch May 21, 2020 02:33
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. labels May 21, 2020
@TomShawn
Copy link
Contributor

TomShawn commented May 21, 2020

@letientai299 Thanks for your contribution!
@nolouch PTAL and check which version this PR applies to, thanks!

@TomShawn
Copy link
Contributor

TomShawn commented May 29, 2020

@shafreeck PTAL

TomShawn
TomShawn approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented May 29, 2020

@yikeke Please help merge this PR because I am not yet authorized to merge PR in this repo, thanks!

shafreeck
shafreeck approved these changes May 29, 2020
View reviewed changes
Copy link

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 052e9b9 into pingcap:master May 29, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 29, 2020
@letientai299 @TomShawn @sre-bot
Update Go requirements (pingcap#2600)
d396677 
* Update Go requirements

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request May 29, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

cherry pick to release-4.0 in PR #2632

TomShawn added a commit that referenced this pull request May 29, 2020
@sre-bot @letientai299 @TomShawn
Update Go requirements (#2600) (#2632)
7ffedd8 
* Update Go requirements

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: Tai Le <letientai299@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request May 29, 2020
Merged
5 tasks
This was referenced May 29, 2020
Merged
Merged
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

+2 more reviewers

@shafreeck shafreeck shafreeck approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@letientai299 @CLAassistant @TomShawn @sre-bot @shafreeck @nolouch @toutdesuite