Skip to content

Conversation

@Anastasia-Lu
Copy link

What is changed, added or deleted? (Required)

Translate the troubleshoot doc for TiCDC till the end of the second subtitle.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 22, 2020
@CLAassistant
Copy link

CLAassistant commented May 22, 2020

CLA assistant check
All committers have signed the CLA.


# Common Problems and Troubleshooting

This document includes some common problems while using TiCDC and appropriate solutions. It also summarizes some common operation failures and ways to fix them.
Copy link
Member

@lilin90 lilin90 May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adverbial clauses can omit the subject (and the be verb) only if the subject of the dependent (the adverbial clause) is the same as that of the independent clause. Multiple similar issues exist in this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I have added possible subjects (not 100% sure). The subject seemed vague to me in some original sentences, because I didn't get the whole picture of TiCDC.


## How to choose start-ts while starting a task

First, you should know that the `start-ts` of a replication task corresponds to a TSO of the upstream TiDB cluster. The replication task will start its data request from this TSO. Therefore, the `start-ts` should meet two conditions below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit the use of should in user documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that should (111 times), need(s) to (125 times) and must (118 times) are almost equally used in current TiDB docs and their links, but should seldom goes with user or you . So, I changed some of should to need to or must.


## When a task gets started, it prompts that some tables cannot be replicated

When using `cdc cli changefeed create` to create a replication task, it will check if the upstream tables comply with the [restrictions](/ticdc/ticdc-overview.md#restrictions). If not, it will prompt that `some tables are not eligible to replicate` and list out the ineligible tables. If you choose `Y` or `y`, you will continue creating the replication task and automatically ignore all the updates of these ineligible tables. If you choose other inputs, the replication task will not be created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made subjects clearer.

@yikeke yikeke added status/require-change Needs the author to address comments. translation/no-need No need to translate this PR. labels May 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2020

@Anastasia-Lu, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

@Anastasia-Lu, please update your pull request.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@Anastasia-Lu, please update your pull request.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2020

@Anastasia-Lu, please update your pull request.

@yikeke yikeke added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Jun 9, 2020
@yikeke yikeke requested a review from TomShawn June 9, 2020 03:52

# Common Problems and Troubleshooting

This document includes some common problems that you might have while using TiCDC and provides appropriate solutions. It also summarizes some common operation failures and ways to fix them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document includes some common problems that you might have while using TiCDC and provides appropriate solutions. It also summarizes some common operation failures and ways to fix them.
This document includes some common problems that you might have while using TiCDC and provides appropriate solutions. It also summarizes some common operation problems and ways to fix them.


First, you need to know that the `start-ts` of a replication task corresponds to a TSO of the upstream TiDB cluster. The replication task will start its data request from this TSO. Therefore, the `start-ts` should meet two conditions below:

- The value of `start-ts` must be larger than current `tikv_gc_safe_point`, otherwise, an error would occur when creating the task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The value of `start-ts` must be larger than current `tikv_gc_safe_point`, otherwise, an error would occur when creating the task.
- The value of `start-ts` must be larger than current `tikv_gc_safe_point` value. Otherwise, an error will occurs when you create a task.

- The value of `start-ts` must be larger than current `tikv_gc_safe_point`, otherwise, an error would occur when creating the task.
- While starting a task, you need to ensure that the downstream has already got all the data previous to `start-ts`. You can relax this requirement accordingly, if the replication task is for message queue or other scenarios, in which strict data consistency between upstream and downstream is not strictly required.

If `start-ts` is not specified or specified as `0`, when a replication task gets started, TiCDC will get the current TSO from PD and start to replicate data from it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If `start-ts` is not specified or specified as `0`, when a replication task gets started, TiCDC will get the current TSO from PD and start to replicate data from it.
If `start-ts` is not specified or specified as `0`, when a replication task is started, TiCDC will get the current TSO from PD and start to replicate data from this TSO.


## When a task gets started, it prompts that some tables cannot be replicated

When you use `cdc cli changefeed create` to create a replication task, TiCDC will check if the upstream tables comply with the [restrictions](/ticdc/ticdc-overview.md#restrictions). If they don't, TiCDC will prompt that `some tables are not eligible to replicate`, and will list out the ineligible tables. If you choose `Y` or `y`, TiCDC will continue creating the replication task and automatically ignore all the updates of these ineligible tables. If you choose other inputs, the replication task will not be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you use `cdc cli changefeed create` to create a replication task, TiCDC will check if the upstream tables comply with the [restrictions](/ticdc/ticdc-overview.md#restrictions). If they don't, TiCDC will prompt that `some tables are not eligible to replicate`, and will list out the ineligible tables. If you choose `Y` or `y`, TiCDC will continue creating the replication task and automatically ignore all the updates of these ineligible tables. If you choose other inputs, the replication task will not be created.
When you execute `cdc cli changefeed create` to create a replication task, TiCDC will check whether the upstream tables meet the [restrictions](/ticdc/ticdc-overview.md#restrictions). If not, TiCDC will prompt that `some tables are not eligible to replicate`, and will list out the ineligible tables. If you choose `Y` or `y`, TiCDC will continue creating the replication task and automatically ignore all the updates of these ineligible tables. If you choose other inputs, the replication task will not be created.

@TomShawn
Copy link
Contributor

TomShawn commented Jun 9, 2020

The change of this PR is made in #2751. So I'll close this PR.

@TomShawn TomShawn closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants