Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented May 28, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added type/bugfix This PR fixes a bug. translation/no-need No need to translate this PR. labels May 28, 2020
@TomShawn TomShawn requested a review from ran-huang May 28, 2020 03:17
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR's assignee is translating this PR. and removed translation/no-need No need to translate this PR. labels May 28, 2020
@TomShawn TomShawn self-assigned this May 28, 2020
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

@yikeke yikeke merged commit a3ce0dd into pingcap:master May 28, 2020
@yikeke
Copy link
Contributor

yikeke commented May 28, 2020

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

cherry pick to release-4.0 in PR #2625

sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
yikeke pushed a commit that referenced this pull request May 28, 2020
* cherry pick #2622 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflicts

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the refine-format-typo branch June 10, 2020 09:51
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 12, 2020
@TomShawn TomShawn removed their assignment Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants