Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 1, 2020

What is changed, added or deleted? (Required)

Add a doc for offline deploying TiDB using TiUP.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 1, 2020
@ran-huang ran-huang marked this pull request as ready for review June 3, 2020 04:17
@ran-huang ran-huang changed the title [WIP]tiup: add doc for offline deployment how-to/deploy: add doc for offline deployment using tiup Jun 3, 2020
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ran-huang and others added 2 commits June 5, 2020 17:45
Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 5, 2020

I made a commit. Please merge it if you have no further problem. @ran-huang

@ran-huang ran-huang merged commit e6dd2d8 into pingcap:master Jun 5, 2020
@ran-huang ran-huang deleted the tiup-offline-deploy branch June 5, 2020 11:25
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

cherry pick to release-4.0 in PR #2710

yikeke pushed a commit that referenced this pull request Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants