Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 9, 2020

What is changed, added or deleted? (Required)

Update parameters and examples of load data

close #2719

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.0 labels Jun 9, 2020
@ran-huang ran-huang requested review from imtbkcat, wshwsh12 and yikeke June 9, 2020 08:43
@ran-huang
Copy link
Contributor Author

pingcap/docs-cn#2568 applies to master, v4.0, v3.1, and v3.0.
pingcap/docs-cn#3335 applies to master and v4.0.
I'll edit the cherry-picked PRs accordingly.

@yikeke yikeke requested review from TomShawn and removed request for yikeke June 9, 2020 09:36
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Jun 10, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 10, 2020

PTAL @TomShawn @imtbkcat

@TomShawn
Copy link
Contributor

LGTM

@TomShawn TomShawn added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2020
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit be16851 into pingcap:master Jun 11, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-3.0 in PR #2801

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-3.1 in PR #2802

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-4.0 in PR #2803

sre-bot added a commit that referenced this pull request Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot added a commit that referenced this pull request Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot added a commit that referenced this pull request Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@ran-huang ran-huang deleted the sql-load-data branch July 30, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing reference to variable in LOAD DATA document

5 participants