Skip to content

Conversation

@bobotu
Copy link

@bobotu bobotu commented Jun 12, 2020

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2020

CLA assistant check
All committers have signed the CLA.

@bobotu bobotu added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jun 12, 2020
@yikeke yikeke requested a review from ran-huang June 15, 2020 11:29
Co-authored-by: Ran <huangran@pingcap.com>
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@bobotu Please involve a technical reviewer~ Thanks!

@bobotu bobotu requested a review from imtbkcat June 16, 2020 06:09
@bobotu
Copy link
Author

bobotu commented Jun 16, 2020

PTAL @imtbkcat

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 473634e into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2898

ti-srebot added a commit that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants