-
Notifications
You must be signed in to change notification settings - Fork 709
*: add experimental warnings #2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
@yikeke, PTAL. |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
PTAL @yikeke |
…herry_pick_sw_exper
|
|
||
| # TiDB Dashboard Introduction | ||
|
|
||
| > **Warning:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not from https://github.com/pingcap/docs-cn/pull/3330/files. Where does this warning come from? @jackysp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note should be in post-installation-check.md. See 16ce338. Is it okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to keep this note in dashboard/dashboard-intro.md. I will add this note in docs-cn later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this note in pingcap/docs-cn#3675
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
|
/merge |
|
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2893 |
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?