Skip to content

Conversation

@jackysp
Copy link
Member

@jackysp jackysp commented Jun 12, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp changed the title *: add experimental warning *: add experimental warnings Jun 12, 2020
@yikeke yikeke self-requested a review June 12, 2020 11:54
@yikeke yikeke added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

@yikeke, PTAL.

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 14, 2020
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp and others added 3 commits June 15, 2020 21:05
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp
Copy link
Member Author

jackysp commented Jun 15, 2020

PTAL @yikeke

@yikeke yikeke removed the status/require-change Needs the author to address comments. label Jun 16, 2020

# TiDB Dashboard Introduction

> **Warning:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not from https://github.com/pingcap/docs-cn/pull/3330/files. Where does this warning come from? @jackysp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@yikeke yikeke Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note should be in post-installation-check.md. See 16ce338. Is it okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to keep this note in dashboard/dashboard-intro.md. I will add this note in docs-cn later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this note in pingcap/docs-cn#3675

yikeke and others added 3 commits June 16, 2020 13:28
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@yikeke yikeke merged commit 4d347f4 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2893

ti-srebot added a commit that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@TomShawn TomShawn mentioned this pull request Jun 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants