Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 12, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@yikeke yikeke requested review from jackysp and ran-huang June 12, 2020 10:42
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 12, 2020
Co-authored-by: Ran <huangran@pingcap.com>
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Jun 15, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Jun 15, 2020

PTAL @jackysp

@yikeke yikeke added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jun 15, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2020

CLA assistant check
All committers have signed the CLA.

@ti-srebot
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Jun 15, 2020

The bot needs to sign the CLA. @zhouqiang-cl @you06

@ti-srebot ti-srebot merged commit 6ecb66f into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@you06
Copy link
Contributor

you06 commented Jun 15, 2020

@jackysp I've signed it for bot.

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2868

ran-huang pushed a commit that referenced this pull request Jun 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke deleted the update-txn-isolation branch June 15, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants