Skip to content

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 15, 2020

What is changed, added or deleted? (Required)

Add binlog-control.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 15, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested review from TomShawn and removed request for yikeke June 15, 2020 11:57
@yikeke
Copy link
Contributor

yikeke commented Jun 15, 2020

Please help review this PR. @CaitinChen

@yikeke yikeke requested review from CaitinChen and removed request for TomShawn June 15, 2020 11:59
-ssl-ca string
The file path of SSL CAs
-ssl-cert string
The file path of the X509 certificate file in the PEM format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line's indentation correct? It is not the same as that in Chinese.
+@WangXiangUSTC

toutdesuite and others added 5 commits June 16, 2020 19:19
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen changed the title Binlog: Add binlog-control.md tidb-binlog: add binlog-control.md Jun 17, 2020
@toutdesuite toutdesuite merged commit 22dff54 into pingcap:master Jun 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2937

toutdesuite added a commit that referenced this pull request Jun 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants