-
Notifications
You must be signed in to change notification settings - Fork 709
tidb-binlog: add binlog-control.md #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WangXiangUSTC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please help review this PR. @CaitinChen |
tidb-binlog/binlog-control.md
Outdated
| -ssl-ca string | ||
| The file path of SSL CAs | ||
| -ssl-cert string | ||
| The file path of the X509 certificate file in the PEM format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line's indentation correct? It is not the same as that in Chinese.
+@WangXiangUSTC
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
CaitinChen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2937 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: toutdesuite <guizhiluo2014@163.com>
What is changed, added or deleted? (Required)
Add binlog-control.md
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?