Skip to content

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 15, 2020

What is changed, added or deleted? (Required)

update diagnose system table doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite marked this pull request as draft June 15, 2020 06:52
@toutdesuite toutdesuite changed the title system tables: system tables: update diagnose system table doc Jun 15, 2020
@toutdesuite toutdesuite requested review from crazycs520 and yikeke June 15, 2020 12:00
@toutdesuite toutdesuite added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 15, 2020
@yikeke yikeke requested review from TomShawn and removed request for yikeke June 15, 2020 12:00
@toutdesuite toutdesuite marked this pull request as ready for review June 15, 2020 12:01
@yikeke
Copy link
Contributor

yikeke commented Jun 15, 2020

Please help review this PR. @TomShawn

toutdesuite and others added 2 commits June 15, 2020 21:59
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@toutdesuite toutdesuite merged commit ad430a8 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2914

@toutdesuite toutdesuite deleted the system-tables branch June 16, 2020 11:56
toutdesuite added a commit that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
TomShawn added a commit to TomShawn/docs that referenced this pull request Jun 17, 2020
TomShawn added a commit that referenced this pull request Jun 17, 2020
* update SQL diagnotics document

* fix ci

* Update system-tables/system-table-sql-diagnostics.md

* commit changes in #2866

Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants