Skip to content

tutorial: add tidb best practice #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 28, 2020
Merged

tutorial: add tidb best practice #2871

merged 12 commits into from
Jun 28, 2020

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang marked this pull request as ready for review June 16, 2020 07:43
@ran-huang ran-huang requested review from kissmydb and yikeke June 16, 2020 09:15
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 16, 2020
@yikeke yikeke requested a review from CaitinChen June 22, 2020 02:19
@yikeke
Copy link
Contributor

yikeke commented Jun 22, 2020

This PR ports https://pingcap.com/blog/2017-07-24-tidbbestpractice/ to TiDB docs. Please help review this PR. @CaitinChen

CaitinChen
CaitinChen reviewed Jun 24, 2020
View reviewed changes
CaitinChen
CaitinChen reviewed Jun 24, 2020
View reviewed changes
ran-huang and others added 2 commits June 24, 2020 22:23
@ran-huang @CaitinChen
Apply suggestions from code review
626aba9 
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
@ran-huang
replace Key with key
69eda00
@ran-huang
Copy link
Contributor Author

ran-huang commented Jun 24, 2020

@CaitinChen PTAL at this commit 69eda00. I replaced all unnecessary Key with key.

@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Jun 28, 2020
CaitinChen
CaitinChen approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

ran-huang commented Jun 28, 2020

@kissmydb PTAL~ Thanks!

@yikeke
Copy link
Contributor

yikeke commented Jun 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 76b0e64 into pingcap:master Jun 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 28, 2020
@ran-huang @ti-srebot
cherry pick pingcap#2871 to release-4.0
7a7ea2b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

cherry pick to release-4.0 in PR #3055

ran-huang added a commit that referenced this pull request Jun 28, 2020
@ti-srebot @ran-huang
cherry pick #2871 to release-4.0 (#3055)
0e7f576 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the best-practice branch July 30, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yikeke yikeke Awaiting requested review from yikeke

@kissmydb kissmydb Awaiting requested review from kissmydb

1 more reviewer

@CaitinChen CaitinChen CaitinChen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @yikeke @ti-srebot @CaitinChen