Skip to content

*: update "change column" and "begin" #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2020
Merged

*: update "change column" and "begin" #2922

merged 5 commits into from
Jun 18, 2020

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Update "change column" and "begin".

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke mentioned this pull request Jun 17, 2020
Merged
5 tasks
yikeke
yikeke reviewed Jun 17, 2020
View reviewed changes
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 17, 2020
AilinKid
AilinKid reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zimulala
Copy link
Contributor Author

zimulala commented Jun 18, 2020

PTAL @yikeke

@yikeke
Copy link
Contributor

yikeke commented Jun 18, 2020

@AilinKid Hi you need to sign the CLA.

@AilinKid
Copy link
Contributor

AilinKid commented Jun 18, 2020

@AilinKid Hi you need to sign the CLA.

great, done~

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 18, 2020
yikeke
yikeke approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 18, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 18, 2020

Your auto merge job has been accepted, waiting for:

  • 2926

@zimulala zimulala merged commit 01d5e2d into pingcap:master Jun 18, 2020
@zimulala zimulala deleted the change-col branch June 18, 2020 07:24
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
@zimulala @ti-srebot
cherry pick pingcap#2922 to release-4.0
bf192bc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 18, 2020

cherry pick to release-4.0 in PR #2952

yikeke pushed a commit that referenced this pull request Jun 18, 2020
@ti-srebot @zimulala
cherry pick #2922 to release-4.0 (#2952)
3ffdbc1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lynn <zimu_xia@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid left review comments

+1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zimulala @CLAassistant @yikeke @AilinKid @ti-srebot