Skip to content

tutorial: add load-base-split #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2020
Merged

tutorial: add load-base-split #2933

merged 5 commits into from
Jul 2, 2020

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 17, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Add the configure-load-base-split.md file

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 17, 2020
@ran-huang ran-huang requested review from lhy1024 and yikeke June 17, 2020 07:49
lhy1024
lhy1024 reviewed Jun 17, 2020
View reviewed changes
ran-huang and others added 2 commits June 17, 2020 17:21
lhy1024
lhy1024 reviewed Jun 17, 2020
View reviewed changes
@yikeke yikeke requested review from lilin90 and removed request for yikeke June 19, 2020 03:56
@lilin90 lilin90 added size/medium Changes of a medium size. status/require-change Needs the author to address comments. labels Jun 29, 2020
lilin90
lilin90 reviewed Jun 30, 2020
View reviewed changes
@ran-huang @lilin90 @lhy1024
Apply suggestions from code review
c63dcc4 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
lhy1024
lhy1024 reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang removed the status/require-change Needs the author to address comments. label Jun 30, 2020
@ran-huang ran-huang requested a review from lilin90 July 1, 2020 07:45
lilin90
lilin90 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jul 2, 2020

/merge

@lilin90 lilin90 merged commit c458337 into pingcap:master Jul 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
@ran-huang @ti-srebot
cherry pick pingcap#2933 to release-4.0
3e33c27 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 2, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 2, 2020

cherry pick to release-4.0 in PR #3110

ran-huang added a commit that referenced this pull request Jul 2, 2020
@ti-srebot @ran-huang
cherry pick #2933 to release-4.0 (#3110)
11b8a47 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the load-base-split branch July 2, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhy1024 lhy1024 lhy1024 left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

No one assigned

Labels

size/medium Changes of a medium size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @lilin90 @ti-srebot @lhy1024