Skip to content

Conversation

@WalterWj
Copy link
Contributor

@WalterWj WalterWj commented Jun 24, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from Damon-Guo and yikeke June 24, 2020 11:37
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 24, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 24, 2020

Hi the original Chinese PR has only two applicable versions - dev and v4.0. But you ticked the 3.1 version in this PR, did you do it on purpose? @WalterWj

@ti-srebot
Copy link
Contributor

@yikeke, @Damon-PingCap, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@yikeke, @Damon-PingCap, PTAL.

@yikeke yikeke requested review from lilin90 and removed request for yikeke June 30, 2020 03:31
@ti-srebot
Copy link
Contributor

@lilin90, @Damon-PingCap, PTAL.

@TomShawn TomShawn mentioned this pull request Jul 6, 2020
5 tasks
@lilin90 lilin90 added the size/large Changes of a large size. label Jul 7, 2020
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jul 7, 2020
lilin90 and others added 11 commits July 7, 2020 20:20
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-srebot
Copy link
Contributor

@lilin90, @Damon-PingCap, PTAL.

@ti-srebot
Copy link
Contributor

@WalterWj, please update your pull request.

@ti-srebot
Copy link
Contributor

@lilin90, @Damon-PingCap, PTAL.

@lilin90
Copy link
Member

lilin90 commented Jul 13, 2020

Hi the original Chinese PR has only two applicable versions - dev and v4.0. But you ticked the 3.1 version in this PR, did you do it on purpose? @WalterWj

I've checked the Chinese documentation and saw that this file does not exist in v3.1, so I unticked v3.1. @yikeke @WalterWj FYI.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 13, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lilin90 lilin90 merged commit cf5794f into pingcap:master Jul 13, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3255

lilin90 pushed a commit that referenced this pull request Jul 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Wang Jun <277372664@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants