Skip to content

integrate tiflash faq into tidb-faq.md and add aliases; add one lightning faq #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2020
Merged

integrate tiflash faq into tidb-faq.md and add aliases; add one lightning faq #3069

merged 5 commits into from
Jun 30, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 30, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jun 30, 2020
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 30, 2020
@yikeke yikeke requested review from windtalker and removed request for ilovesoup and kissmydb June 30, 2020 03:49
@yikeke yikeke added needs-cherry-pick-4.0 and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 30, 2020
@yikeke yikeke changed the title faq: integrate tiflash faq into tidb-faq.md and add aliases integrate tiflash faq into tidb-faq.md and add aliases; add one lightning faq Jun 30, 2020
windtalker
windtalker approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested review from 3pointer and windtalker June 30, 2020 04:07
TomShawn
TomShawn approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn TomShawn added the special-week PR from Document Special Week. label Jun 30, 2020
@yikeke @TomShawn
Apply suggestions from code review
76355de 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jun 30, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 30, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 9d79246 into master Jun 30, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 30, 2020
@yikeke @ti-srebot
cherry pick pingcap#3069 to release-4.0
8e303bb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 30, 2020

cherry pick to release-4.0 in PR #3080

ti-srebot added a commit that referenced this pull request Jun 30, 2020
@ti-srebot
integrate tiflash faq into tidb-faq.md and add aliases; add one light…
23a563f 
…ning faq (#3069) (#3080)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@yikeke yikeke deleted the update-tiflash-faq branch August 3, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

@windtalker windtalker Awaiting requested review from windtalker

@3pointer 3pointer Awaiting requested review from 3pointer

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yikeke @ti-srebot @windtalker @TomShawn