Skip to content

commit-message: add file: tidb-storage.md #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 20, 2020
Merged

commit-message: add file: tidb-storage.md #3071

merged 12 commits into from
Jul 20, 2020

Conversation

@zhouyueyue1115
Copy link
Contributor

@zhouyueyue1115 zhouyueyue1115 commented Jun 30, 2020 •
edited by yikeke
Loading

Signed-off-by: zhouyueyue1115 1024828678@qq.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@zhouyueyue1115
commit-message: add file: tidb-storage.md
6217295 
Signed-off-by: zhouyueyue1115 <1024828678@qq.com>
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yikeke yikeke requested review from SunRunAway and TomShawn June 30, 2020 07:06
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 2, 2020

@SunRunAway, @TomShawn, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 4, 2020

@SunRunAway, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

@SunRunAway, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first round of review. The rest will be reviewed soon~

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 12, 2020

@TomShawn, @SunRunAway, PTAL.

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 13, 2020
TomShawn
TomShawn reviewed Jul 13, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second round of review.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 15, 2020

@zhouyueyue1115, please update your pull request.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 15, 2020

@TomShawn, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

@zhouyueyue1115, please update your pull request.

@zhouyueyue1115 @TomShawn
Apply suggestions from code review
51d0169 
LGTM

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Jul 17, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 17, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@TomShawn, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@zhouyueyue1115, please update your pull request.

SunRunAway
SunRunAway reviewed Jul 20, 2020
View reviewed changes
@TomShawn @SunRunAway
Apply suggestions from code review
1f071c7 
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
@TomShawn
Copy link
Contributor

TomShawn commented Jul 20, 2020

@SunRunAway Comments addressed, PTAL again, thanks

SunRunAway
SunRunAway reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Jul 20, 2020
@TomShawn TomShawn merged commit e9d71e3 into pingcap:master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
@zhouyueyue1115 @ti-srebot
cherry pick pingcap#3071 to release-4.0
221740a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

/run-all-tests

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

cherry pick to release-4.0 in PR #3340

TomShawn pushed a commit that referenced this pull request Jul 20, 2020
@ti-srebot @zhouyueyue1115
cherry pick #3071 to release-4.0 (#3340)
fbae469 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: zhouyueyue1115 <yueyue.zhou@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhouyueyue1115 @CLAassistant @ti-srebot @TomShawn @SunRunAway @yikeke