Skip to content

Conversation

@imtbkcat
Copy link

@imtbkcat imtbkcat commented Jun 30, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@imtbkcat imtbkcat requested a review from yikeke June 30, 2020 04:22
@yikeke yikeke requested review from TomShawn and zz-jason and removed request for yikeke June 30, 2020 04:43
@yikeke yikeke added needs-cherry-pick-3.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@TomShawn TomShawn added the special-week PR from Document Special Week. label Jun 30, 2020
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Jun 30, 2020
@ti-srebot
Copy link
Contributor

@imtbkcat, please update your pull request.

@ti-srebot
Copy link
Contributor

@TomShawn, @wwar, @zz-jason, PTAL.

@ti-srebot
Copy link
Contributor

@imtbkcat, please update your pull request.

@ti-srebot
Copy link
Contributor

@TomShawn, @wwar, @zz-jason, PTAL.

Lingyu Song and others added 11 commits July 6, 2020 14:39
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@ti-srebot
Copy link
Contributor

@TomShawn,Thanks for your review.

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@TomShawn TomShawn merged commit 36a26c3 into pingcap:master Jul 6, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jul 6, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3175

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3176

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3177

ti-srebot added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
TomShawn pushed a commit that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lingyu Song <songlingyu@pingcap.com>
ti-srebot added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants