-
Notifications
You must be signed in to change notification settings - Fork 709
update partition-table.md #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
|
@tiancaiamao, @TomShawn, PTAL. |
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
|
@TomShawn, @tiancaiamao, PTAL. |
|
@gengliqi, please update your pull request. |
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
|
@TomShawn, @tiancaiamao, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tiancaiamao PTAL
|
@TomShawn,Thanks for your review. |
|
@gengliqi, please update your pull request. |
|
@TomShawn, @ti-srebot, @tiancaiamao, PTAL. |
|
@gengliqi, please update your pull request. |
Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
|
LGTM |
|
@tiancaiamao, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack). |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #3229 |
Signed-off-by: Liqi Geng gengliqiii@gmail.com
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?