Skip to content

Conversation

@gengliqi
Copy link
Contributor

Signed-off-by: Liqi Geng gengliqiii@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from TomShawn and tiancaiamao June 30, 2020 09:20
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@ti-srebot
Copy link
Contributor

@tiancaiamao, @TomShawn, PTAL.

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 2, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @tiancaiamao, PTAL.

@ti-srebot
Copy link
Contributor

@gengliqi, please update your pull request.

Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
@gengliqi gengliqi requested a review from TomShawn July 6, 2020 08:42
@ti-srebot
Copy link
Contributor

@TomShawn, @tiancaiamao, PTAL.

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tiancaiamao PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@ti-srebot
Copy link
Contributor

@TomShawn,Thanks for your review.

@ti-srebot
Copy link
Contributor

@gengliqi, please update your pull request.

@ti-srebot
Copy link
Contributor

@TomShawn, @ti-srebot, @tiancaiamao, PTAL.

@ti-srebot
Copy link
Contributor

@gengliqi, please update your pull request.

gengliqi and others added 2 commits July 10, 2020 17:17
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor

@tiancaiamao, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@TomShawn TomShawn merged commit a369665 into pingcap:master Jul 10, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 10, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3229

ti-srebot added a commit that referenced this pull request Jul 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants