Skip to content

Conversation

@SE-Bin
Copy link
Contributor

@SE-Bin SE-Bin commented Jun 30, 2020

add topn-limit-push-down

What is changed, added or deleted? (Required)

Note: CI fails because this doc links to a new file in this unmerged PR #3043.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

add topn-limit-push-down
@github-actions github-actions bot requested a review from TomShawn June 30, 2020 12:59
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 30, 2020
@yikeke yikeke added needs-cherry-pick-2.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 1, 2020
@yikeke yikeke requested review from LittleFall and ran-huang and removed request for TomShawn July 1, 2020 02:26
@ran-huang ran-huang requested a review from zz-jason July 3, 2020 02:58
@ti-srebot
Copy link
Contributor

@ran-huang, @zz-jason, @LittleFall, PTAL.

@ran-huang ran-huang added the status/require-change Needs the author to address comments. label Jul 6, 2020
@ti-srebot
Copy link
Contributor

@ran-huang, @zz-jason, @LittleFall, PTAL.

SE-Bin and others added 10 commits July 7, 2020 20:18
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
@LittleFall
Copy link
Contributor

It's better to replace collation with ordering rule to avoid misunderstandings with the collation of sql.

Is there any ref on this one? Like, how would you choose between ordering rule and sorting rule?

No, collation generally refers to the collation of the character set. You can choose from other options that you think are more appropriate.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Contributor

@LittleFall ok, thanks. Let's go with sorting rules, as sort introduces less ambiguity than order.
I'll update this PR and then request your review again 😀

Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@LittleFall,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@ran-huang ran-huang added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2020
@ran-huang ran-huang merged commit 647c64c into master Jul 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3284

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3285

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3286

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3287

@ran-huang ran-huang deleted the SE-Bin-topn-limit branch July 16, 2020 03:00
ran-huang pushed a commit that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Se-L <Seiferbb@126.com>
ran-huang added a commit that referenced this pull request Jul 16, 2020
* cherry pick #3089 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

Co-authored-by: Se-L <Seiferbb@126.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 16, 2020
* cherry pick #3089 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: Se-L <Seiferbb@126.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 16, 2020
* cherry pick #3089 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Signed-off-by: Ran <huangran@pingcap.com>

* rm deadlink

Co-authored-by: Se-L <Seiferbb@126.com>
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants